Code cleanup, work exclusively with bcrypt, works on Windows#21
Code cleanup, work exclusively with bcrypt, works on Windows#21tminakov wants to merge 3 commits intoPhotoBackup:masterfrom
Conversation
…uration functions to it - separation of logic * FIX - the "list" CLI option works once again * FEAT - skipping of directory writability check, thus allowing to work under Windows
…ser & group permissions in one pass, and is more complete. Minor docstrings updates
…uest attribute, bcrypt it & compare it like this; if the config file does not have bcrypted password - generate it on load
|
Travis failed on py3.2, at the import of |
|
Hi @stephanepechard, any update of the merge, is there something bothering you with the code? I'd really like to see it in, to use as a base for some new development. Thanks, |
|
@tminakov Did you validate your changes on OSes other than Windows? |
|
Yes, on Ubuntu - my main dev environment, and Debian - my main execution one; the Windows' writability check skip is just "to get it done" and for compatibility - but I've tested it there also. |
|
By the way, I should've mentioned it - looked into the 3.2 failure, and it comes from the requests library - it does not support it, as a lot of others also don't: |
2 participants
The changes can be summarized in two major areas:
the password checks are exclusively through bcrypt, thus mitigating timing attacks - inspired from the go implementation, done by @lupine
code cleanup and refactoring:
pwd