Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates lab_sim_behaviors to use the MoveIt Studio vision wrapper header for cv_bridge integration (consistent with the package’s declared dependencies), as part of merging v9.1 into main.
Changes:
- Replaced direct
cv_bridgeinclude withmoveit_studio_vision’scv_bridgewrapper header.
Comments suppressed due to low confidence (1)
src/lab_sim_behaviors/src/compute_tray_place_positions_using_apriltags.cpp:20
- This file uses
sensor_msgs::image_encodings::RGB8andstd::find_if, but does not include the corresponding headers (<sensor_msgs/image_encodings.hpp>and<algorithm>). With the switch away fromcv_bridge/cv_bridge.h, relying on transitive includes becomes more brittle and may break builds depending on whatmoveit_studio_vision/cv_bridge.hppincludes. Add the direct includes here to make compilation deterministic.
#include <moveit_pro_behavior_interface/get_required_ports.hpp>
#include <moveit_pro_behavior_interface/metadata_fields.hpp>
#include <moveit_studio_vision/cv_bridge.hpp>
#include <moveit_studio_vision/image_utils.hpp>
#include <moveit_studio_vision_msgs/msg/object_detection_array.hpp>
#include <opencv2/opencv.hpp>
#include <sensor_msgs/msg/camera_info.hpp>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
shaur-k
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.