Skip to content

Fix: BaseCard height 조절 #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jjangminii merged 1 commit into from
Mar 12, 2026
Merged

Fix: BaseCard height 조절 #314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/design-system/src/components/card/MyBookmarkCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const MyBookmarkCard = ({
nickname && nickname.trim().length > 0 ? nickname : '도토리';

return (
<BaseCard onClick={onClick} className="h-[33.8rem]">
<BaseCard onClick={onClick} className="h-auto">
Copy link
Member

@constantly-dev constantly-dev Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이렇게 되었을때 메모 내용이 길고 짧은 등의 컨텐츠 차이로 인해 같은 리마인드 카드인데 높이가 다른 경우가 생길 가능성은 없나요?? 그렇게 됐을때 같은 북마크 페이지에서 카드 높이가 달라질 수 있을 것 같은데, 그런 가능성은 없는지 궁금합니다.

Copy link
Collaborator Author

@jjangminii jjangminii Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

메모 내용에 대해서 h-[4.2rem] 로 높이 명시해있어서 해당 이슈에 대해서는 문제 없을 것 같습니다.

<div className="flex h-[12rem] w-full items-center justify-center overflow-hidden bg-[#F8F8FA]">
{imageUrl ? (
<img src={imageUrl} className="h-full w-full object-cover" />
Expand Down
Loading