Revert #4366

[lybcodes]

No description provided.

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Summary
This PR reverts the previous changes from #4366, removing hardcoded Go toolchain version settings and related environment variables from CI pipeline scripts and presubmit job configs. The approach is straightforward—deleting the added environment exports and related commands to restore the prior state. The changes are minimal and cleanly done, properly reverting the intended modifications.

---

Critical Issues

None identified. The PR is a revert and does not introduce new logic or functionality.

---

Code Improvements

• Revert Commit Message and Description:
  • File: N/A (PR metadata)
  • Issue: The PR description is empty, which reduces clarity about why this revert is needed.
  • Suggestion: Add a brief explanation describing the reason for reverting #4366 (e.g., stability issues, environment upgrade delays). This helps reviewers and future maintainers understand the context.

---

Best Practices

• Documentation and Comments:

  • Files: pipelines/pingcap/tiflow/latest/ghpr_verify.groovy, prow-jobs/pingcap/ticdc/latest-presubmits.yaml, prow-jobs/pingcap/ticdc/latest-presubmits-next-gen.yaml
  • Issue: The removed code contained comments explaining why the Go toolchain was hardcoded and TODOs for future removal. These comments helped document the temporary workaround.
  • Suggestion: Consider adding a comment in the reverted files or PR description noting that the workaround is now removed because the environment/toolchain issue is resolved. This preserves historical context and aids future debugging.

• Testing Coverage:

  • Since this is a revert of CI configuration changes, ensure that the CI pipelines run successfully with this revert applied. This may not be visible in code but should be verified post-merge.

---

Overall, this PR correctly reverts the previous workaround for Go toolchain inconsistencies. Adding a descriptive PR message and preserving context via comments would improve maintainability.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request reverts a previous change (#4366) that introduced temporary Go toolchain and cache management configurations across several CI/CD pipelines and Prow jobs. The original changes were implemented to address inconsistencies with Go versions, specifically go1.25.8. By reverting these changes, the PR indicates that the temporary workarounds are no longer necessary, streamlining the build and test processes by removing redundant environment variable settings and cache cleaning steps.

Highlights

• CI/CD Configuration Reverted: Reverted temporary Go toolchain and cache management configurations in the ghpr_verify.groovy pipeline for tiflow.
• Prow Job Cleanup (TICDC Next-Gen): Removed temporary Go toolchain and cache settings from the ticdc next-gen presubmit unit test Prow job configuration.
• Prow Job Cleanup (TICDC Standard): Eliminated temporary Go toolchain and cache settings from the standard ticdc presubmit unit test Prow job configuration.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request reverts the temporary changes introduced in #4366, which were workarounds for Go toolchain inconsistencies in the CI environment. The changes remove the hardcoded GOTOOLCHAIN and related cache cleaning commands from ghpr_verify.groovy and two Prow job configurations. This cleanup is appropriate now that the underlying CI environment has been updated. The changes are correct and improve the maintainability of the CI scripts.

[dillon-zheng]

/approve

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dillon-zheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• pipelines/OWNERS [dillon-zheng]
• prow-jobs/OWNERS [dillon-zheng]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment