chore(prow-jobs): update client-go nextgen base image to go 1.25.12 - #4857
chore(prow-jobs): update client-go nextgen base image to go 1.25.12#4857disksing wants to merge 1 commit into
Conversation
The master branch upgraded Go to 1.25.12 (tikv/client-go#2036), so the nextgen integration job now fails at bootstrap with 'go.mod requires go >= 1.25.12' because the pinned base image (v2026.4.12-27-g440b0c8) ships Go 1.25.10 and GOTOOLCHAIN is set to local. Update the base image to v2026.7.12-6-gc8582dde-go1.25 which bundles Go 1.25.12. Signed-off-by: disksing <i@disksing.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![ti-chi-bot[bot]](https://avatars.githubusercontent.com/in/214286?s=60&v=4){kind=small}
There was a problem hiding this comment.
I have already done a preliminary review for you, and I hope to help you do a better job.
Summary
This PR updates the base image version used in the pull-integration-test-nextgen prow job for tikv/client-go, bumping the Go toolchain from 1.25.10 to 1.25.12 to align with the updated Go version requirement of the codebase. The change is minimal, focused, and correctly targets the relevant YAML file. The overall quality is good and the rationale is clearly documented.
Code Improvements
-
Explicitly specify image digest or tag stability
- File:
prow-jobs/tikv/client-go/latest-presubmits-nextgen.yamlline 128 - Issue: The image tag
v2026.7.12-6-gc8582dde-go1.25appears to be a moving tag (including a commit hash), which can lead to non-reproducible builds if the image is rebuilt or overwritten. - Suggestion: Use an immutable image digest (SHA256) or a fully pinned tag if available to ensure build reproducibility and traceability. This is especially important in CI environments.
- Example:
or ensure the tag is a static release.
image: ghcr.io/pingcap-qe/ci/base@sha256:<digest>
- File:
-
Update related documentation or tooling if applicable
- If there exist any documentation files or scripts referencing the previous base image version or Go version, consider updating them alongside this change to keep all references consistent.
Best Practices
-
Add a comment in the YAML file explaining the image update
- File:
prow-jobs/tikv/client-go/latest-presubmits-nextgen.yamlline ~125 - Issue: While the PR description is clear, the YAML file itself lacks inline comments explaining why this particular image version is pinned. This may help future maintainers.
- Suggestion: Add a brief comment above the
imageline:# Updated base image to Go 1.25.12 to satisfy tikv/client-go's minimum toolchain version requirement image: ghcr.io/pingcap-qe/ci/base:v2026.7.12-6-gc8582dde-go1.25
- File:
-
Testing and validation
- Confirm that the updated prow job runs successfully with the new image and Go version. If not already done, add or update job run logs or test results in the PR to prove the fix.
No critical issues found, as this is a straightforward version bump. The PR is well targeted and justified. Addressing the above points will improve build reproducibility and maintainability.
|
|
|
Closing as duplicate: #4858 (merged) applies the exact same base image bump (v2026.7.12-6-gc8582dde-go1.25, Go 1.25.12) to this job. |
1 participant
What
Update the base image of the
pull-integration-test-nextgenjob fortikv/client-gofromv2026.4.12-27-g440b0c8-go1.25(Go 1.25.10) tov2026.7.12-6-gc8582dde-go1.25(Go 1.25.12).Why
tikv/client-goupgraded its Go toolchain requirement to 1.25.12 (tikv/client-go#2036, merged into master). The job setsGOTOOLCHAIN=local, so it fails at bootstrap with:Related