Skip to content

Fix TypeError in test_vmr_conversion_different_gases loop iteration#509

Merged
cloneofghosts merged 3 commits into
add-silam-aqifrom
copilot/sub-pr-465
Jan 8, 2026
Merged

Fix TypeError in test_vmr_conversion_different_gases loop iteration#509
cloneofghosts merged 3 commits into
add-silam-aqifrom
copilot/sub-pr-465

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 8, 2026

  • Add FMI Silam air quality ingest script
  • Add wildfire smoke ingest for IS4FIRES v2.0
  • Add VMR to concentration conversion utilities
  • Add comprehensive tests for AQI calculation
  • Fix test_vmr_conversion_different_gases TypeError
  • Refactor loop to use .values() since name is unused

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: cloneofghosts <10248058+cloneofghosts@users.noreply.github.com>
Copilot AI changed the title [WIP] Add FMI Silam air quality ingest and wildfire smoke ingest Fix TypeError in test_vmr_conversion_different_gases loop iteration Jan 8, 2026
Copilot AI requested a review from cloneofghosts January 8, 2026 16:06
@cloneofghosts
Copy link
Copy Markdown
Collaborator

@copilot While that fix works - name isn't being used anywhere in the loop so am wondering if it's fine as-is or should be changed?

Co-authored-by: cloneofghosts <10248058+cloneofghosts@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Jan 8, 2026

@copilot While that fix works - name isn't being used anywhere in the loop so am wondering if it's fine as-is or should be changed?

Changed to use gases.values() instead in commit 3916323. Since the gas name isn't used in the loop, iterating over just the values is cleaner and more Pythonic.

@cloneofghosts cloneofghosts marked this pull request as ready for review January 8, 2026 16:16
@cloneofghosts cloneofghosts merged commit 100b074 into add-silam-aqi Jan 8, 2026
9 checks passed
@cloneofghosts cloneofghosts deleted the copilot/sub-pr-465 branch January 8, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants