Add NBM regional models#593
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request expands the data ingestion capabilities by adding support for NBM regional models. It introduces dedicated processing scripts for Alaska, Puerto Rico, Hawaii, and Guam, and updates the necessary configuration files to ensure these new models are correctly handled by the existing infrastructure. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces local ingest scripts for NBM data across Alaska, Guam, Hawaii, and Puerto Rico, along with corresponding configuration updates. The review feedback identifies several critical issues, including incorrect hardcoded grid dimensions and process paths in the regional scripts that would lead to runtime errors. Additionally, the reviewer noted violations of the project's style guide regarding variable naming and docstring formats, and recommended improvements to command-line string construction and error handling to enhance code robustness.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
Fixed the few gemini review comments and this should be good to review. I just copied the NBM script for each regional model and then just removed any data not available for the region. |
|
@alexander0042 Do we need to do the same historic update here as well? Also some regions don't have precipitation type so will have to do the fallback based on temperature? |
Describe the change
Adds ingest for the NBM regional models (Alaska (AK), Puerto Rico (PR), Hawaii (HI) and Guam (GU)) based on the existing NBM model template.
As far as I'm aware everything is the same for the regonal models except for what fields are available. Based on this table I'm pretty sure I got everything correct but should double check.
I saw you started a PR to fix the historical data which will need to be applied here whenever that is good to go.
Type of change
Checklist