Skip to content

Add NBM regional models#593

Open
cloneofghosts wants to merge 8 commits into
devfrom
nbm-regional-models
Open

Add NBM regional models#593
cloneofghosts wants to merge 8 commits into
devfrom
nbm-regional-models

Conversation

@cloneofghosts
Copy link
Copy Markdown
Collaborator

Describe the change

Adds ingest for the NBM regional models (Alaska (AK), Puerto Rico (PR), Hawaii (HI) and Guam (GU)) based on the existing NBM model template.

As far as I'm aware everything is the same for the regonal models except for what fields are available. Based on this table I'm pretty sure I got everything correct but should double check.

I saw you started a PR to fix the historical data which will need to be applied here whenever that is good to go.

Type of change

  • Bugfixes to existing code
  • Breaking change
  • New API Version
  • General Improvement
  • Code quality improvements to existing code or addition of tests
  • Documentation Updates

Checklist

  • This pull request fixes issue: fixes NBM Regional Models pirateweather#195
  • Code builds locally. Your pull request won't be merged unless tests pass
  • Code has been formatted using ruff
  • The TimeMachine version (in API/timemachine.py) matches the API version number

@cloneofghosts cloneofghosts added the enhancement New feature or request label Apr 3, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request expands the data ingestion capabilities by adding support for NBM regional models. It introduces dedicated processing scripts for Alaska, Puerto Rico, Hawaii, and Guam, and updates the necessary configuration files to ensure these new models are correctly handled by the existing infrastructure.

Highlights

  • New NBM Regional Model Ingest: Added support for ingesting NBM regional models for Alaska (AK), Puerto Rico (PR), Hawaii (HI), and Guam (GU).
  • Configuration Updates: Updated shared constants and ingest utilities to include parameters for the new regional models.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces local ingest scripts for NBM data across Alaska, Guam, Hawaii, and Puerto Rico, along with corresponding configuration updates. The review feedback identifies several critical issues, including incorrect hardcoded grid dimensions and process paths in the regional scripts that would lead to runtime errors. Additionally, the reviewer noted violations of the project's style guide regarding variable naming and docstring formats, and recommended improvements to command-line string construction and error handling to enhance code robustness.

Comment thread API/NBM_HI_Local_Ingest.py
Comment thread API/NBM_GU_Local_Ingest.py Outdated
Comment thread API/NBM_GU_Local_Ingest.py
Comment thread API/NBM_HI_Local_Ingest.py
Comment thread API/NBM_PR_Local_Ingest.py
Comment thread API/NBM_AK_Local_Ingest.py Outdated
Comment thread API/NBM_AK_Local_Ingest.py
Comment thread API/NBM_AK_Local_Ingest.py
Comment thread API/NBM_HI_Local_Ingest.py Outdated
Comment thread API/NBM_AK_Local_Ingest.py
cloneofghosts and others added 2 commits April 3, 2026 15:44
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@cloneofghosts
Copy link
Copy Markdown
Collaborator Author

Fixed the few gemini review comments and this should be good to review. I just copied the NBM script for each regional model and then just removed any data not available for the region.

@cloneofghosts
Copy link
Copy Markdown
Collaborator Author

@alexander0042 Do we need to do the same historic update here as well? Also some regions don't have precipitation type so will have to do the fallback based on temperature?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority: low

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NBM Regional Models

1 participant