Default to static linking and add mingw support#41
Open
ShyAssassin wants to merge 4 commits intoPistonDevelopers:masterfrom
Open
Default to static linking and add mingw support#41ShyAssassin wants to merge 4 commits intoPistonDevelopers:masterfrom
ShyAssassin wants to merge 4 commits intoPistonDevelopers:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of issues I ran into while cross-compiling for Windows. When using mingw or cross-compiling (with the
prebuilt-libsflag), it now properly uses the mingw-w64 libraries instead of defaulting to the vc2022 ones which don't work with GNU toolchains.The main change though is switching to static linking by default across all build configurations, with a new
dynamic-linkfeature if you specifically want dynamic linking. Before this, the static-link feature was confusing andsrc-buildwould unexpectedly create executables that relied onglfw3.dllat runtime. Now it just statically links everything by default unless you explicitly ask for dynamic linking, which makes way more sense and fixes the weird dependency issues I was hitting.