Open
Conversation
- Implement 'Analog Drift' via micro-randomization of pitch (+/- 1Hz), filter cutoffs (+/- 2%), and decay times (+/- 2%) across all drum models. - Improve master audio routing in `DrumMachine.ts` to include a centralized Compressor and WaveShaper (saturation) for the 'glue' effect. - Refine 808/909 Kick pitch sweeps and 909 Snare sweep timing (30ms). - Ensure consistent phase randomization and cleanup logic to prevent memory leaks. - Set WaveShaper oversample to '4x' and distortion amount to 20 for high-quality analog-style saturation. Co-authored-by: Pitrat-wav <255843145+Pitrat-wav@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update significantly improves the audio quality and authenticity of the procedural drum synthesis by incorporating physical modeling principles from the provided DSP research. Each drum hit now features unique micro-variations in pitch, decay, and timbre, mimicking the behavior of analog circuits. Furthermore, the routing architecture has been updated to pass all drum signals through a master saturation and compression chain, providing a cohesive and punchy 'analog' sound without the use of PCM samples.
PR created automatically by Jules for task 13585321310253457451 started by @Pitrat-wav