Skip to content

DSP Drum Synthesis Refinement and Velocity Support#45

Open
Pitrat-wav wants to merge 1 commit intomainfrom
feat/dsp-drums-refinement-701738731243400967
Open

DSP Drum Synthesis Refinement and Velocity Support#45
Pitrat-wav wants to merge 1 commit intomainfrom
feat/dsp-drums-refinement-701738731243400967

Conversation

@Pitrat-wav
Copy link
Copy Markdown
Owner

This PR refines the procedural drum synthesis engine to better align with the provided DSP research on TR-808 and TR-909 hardware. Key changes include the addition of velocity sensitivity to all drum models, improved master-bus saturation, and architectural fixes for independent hi-hat volume control. All changes were verified via TypeScript type checking and visual frontend inspection.


PR created automatically by Jules for task 701738731243400967 started by @Pitrat-wav

…lysis.

- Updated TR-808 and TR-909 Kick, Snare, Hi-Hat, and Clap models to support dynamic velocity scaling.
- Implemented independent audio routing for Open Hi-Hat in DrumMachine.
- Refined master saturation curve (tanh-based soft clipping) with amount=20 for improved analog warmth.
- Fixed volume mapping for Open Hi-Hat in audioStore.
- Ensured consistent micro-randomization (analog drift) across all synthesized drum components.

Co-authored-by: Pitrat-wav <255843145+Pitrat-wav@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant