Skip to content

[WIP] Fix credit note builder to respect XML format#8

Closed
Copilot wants to merge 2 commits intomainfrom
copilot/fix-credit-note-builder-format
Closed

[WIP] Fix credit note builder to respect XML format#8
Copilot wants to merge 2 commits intomainfrom
copilot/fix-credit-note-builder-format

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 1, 2026

  • Fix credit note builder to match PEPPOL BIS 3.0 CreditNote format:
    • Remove unused xmlns:cec namespace from CreditNote root element (not in PEPPOL standard)
    • Remove UBLVersionID element (not in PEPPOL BIS 3.0 standard examples)
    • Remove unnecessary fallback values for ID, creditNoteTypeCode, documentCurrencyCode
    • Add support for optional fields in builder: note, accountingCost, taxCurrencyCode, taxPointDate, invoicePeriod
  • Apply same fixes to invoice builder for consistency (remove xmlns:cec, UBLVersionID, add optional fields)
  • Update schemas if needed for PEPPOL compliance
  • Update existing tests to match new output format
  • Add new tests for credit note builder optional fields
  • Verify all tests pass

@codacy-production
Copy link
Copy Markdown

codacy-production bot commented Apr 1, 2026

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity . 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

Agent-Logs-Url: https://github.com/PixelDrive/peppol-toolkit/sessions/1860634c-bd03-4b8e-a8f8-8f81b8acf716

Co-authored-by: SimonLoir <17649337+SimonLoir@users.noreply.github.com>
@SimonLoir SimonLoir closed this Apr 1, 2026
Copilot AI requested a review from SimonLoir April 1, 2026 13:28
Copilot stopped work on behalf of SimonLoir due to an error April 1, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants