Conversation
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| ErrorProne | 11 high |
🟢 Metrics 8 complexity . -6 duplication
Metric Results Complexity 8 Duplication -6
TIP This summary will be updated as you push new changes. Give us feedback
Agent-Logs-Url: https://github.com/PixelDrive/peppol-toolkit/sessions/66585be7-f643-4ca2-bff8-823420d86af2 Co-authored-by: SimonLoir <17649337+SimonLoir@users.noreply.github.com>
- Fix InvoicePeriodSchema: make descriptionCode optional (0..1) - Create Delivery schema (cac:Delivery 0..1) - Create AllowanceCharge schemas (document-level and line-level) - Create AdditionalDocumentReference schema - Update Invoice: add orderReference, billingReference, document references, delivery, allowanceCharge, projectReference - Update CreditNote: inherit new Invoice fields, remove projectReference - Update Line: add commodityClassification, lineAllowanceCharge, baseQuantity, priceAllowanceCharge, update standardItemIdentification and additionalItemProperties to match spec structure - Update PaymentMeans: add paymentDueDate - Update DocumentBuilder: handle all new fields - Update DocumentParser: handle all new fields - Update data files and tests for schema changes Agent-Logs-Url: https://github.com/PixelDrive/peppol-toolkit/sessions/66585be7-f643-4ca2-bff8-823420d86af2 Co-authored-by: SimonLoir <17649337+SimonLoir@users.noreply.github.com>
Agent-Logs-Url: https://github.com/PixelDrive/peppol-toolkit/sessions/66585be7-f643-4ca2-bff8-823420d86af2 Co-authored-by: SimonLoir <17649337+SimonLoir@users.noreply.github.com>
|
@copilot review |
…ne methods - Replace inline boolean expressions with __bool() helper in parser - Fix __buildInvoiceLine/_buildCreditNoteLine losing `this` context when passed as .map() callbacks and using DocumentBuilder.prototype - Call __buildLineItem directly with arrow functions to preserve `this` - Remove now-unused wrapper methods Agent-Logs-Url: https://github.com/PixelDrive/peppol-toolkit/sessions/b68d20b9-7ae6-4674-b8a6-f82e74b3eb83 Co-authored-by: SimonLoir <17649337+SimonLoir@users.noreply.github.com>
Self-review found and fixed two bugs in
|
Uh oh!
There was an error while loading. Please reload this page.