test(compat): add v0.132.0 regression test — entry parsing without formatted_output#92
Merged
Conversation
…formatted_output Codex v0.132.0 (PR #22706) removed the legacy `formatted_output` field from exec_command_end events. The parser fix was shipped in #71 (Fixes #64), but no version-specific regression test existed for v0.132.0 in entry.rs, unlike the pattern established for v0.128.0, v0.130.0, and v0.131.0. Add `v0132_all_standard_entry_types_parse_correctly` in entry.rs that: - Parses all four standard JSONL entry types from a v0.132.0 session - Includes an exec_command_end event with `aggregated_output` only (no `formatted_output`) and asserts the field is absent - Confirms `cli_version: "0.132.0"` is read correctly Fixes #78
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Codex v0.132.0 (PR #22706 "Remove legacy shell output formatting paths") permanently removed the
formatted_outputfield fromexec_command_endevents. The underlying parser fix was shipped in PR #71 (Fixes #64):formatted_outputwas removed from thefinalize_execoutput fallback chain and replaced withaggregated_output-only reads.Issue #78 identified that no v0.132.0-specific regression test existed in
entry.rs, breaking the pattern established for v0.128.0, v0.130.0, and v0.131.0.Changes
src-tauri/src/parser/entry.rs: Addv0132_all_standard_entry_types_parse_correctlytest that:cli_version: "0.132.0"sessionexec_command_endevent withaggregated_outputonly (noformatted_output)formatted_outputis absent from the payloadcli_version: "0.132.0"is read correctly fromsession_metaVerification
cargo test --lib→ 132 tests pass (0 failures)npx vitest run→ 128 tests pass across 12 test filescargo clippy -- -D warnings→ cleanGET /api/settingsreturns valid JSONFixes #78