Skip to content

fix(chart): claimer falls through to image.tag when its own tag is unset #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucasmundim merged 1 commit into from
Jun 7, 2026
Merged

fix(chart): claimer falls through to image.tag when its own tag is unset #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion deployment/openfilter-pipelines-controller/overrides/development.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ image:
tag: "fe613cc832bc53753274fb6e1a178dd8d00d2c33" # {"$imagepolicy": "development:openfilter-pipelines-controller:tag"}
claimerImage:
repository: plainsightai/openfilter-pipelines-claimer
tag: "fe613cc832bc53753274fb6e1a178dd8d00d2c33" # {"$imagepolicy": "development:openfilter-pipelines-controller:tag"}
telemetry:
exporterType: otlp
# Scheme prefix is load-bearing. openfilter ≥ 0.2.1 infers OTLP gRPC TLS
Expand Down
1 change: 0 additions & 1 deletion deployment/openfilter-pipelines-controller/overrides/lab.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ image:
tag: "fe613cc832bc53753274fb6e1a178dd8d00d2c33" # {"$imagepolicy": "lab:openfilter-pipelines-controller:tag"}
claimerImage:
repository: plainsightai/openfilter-pipelines-claimer
tag: "fe613cc832bc53753274fb6e1a178dd8d00d2c33" # {"$imagepolicy": "lab:openfilter-pipelines-controller:tag"}
telemetry:
# Lab has no monitoring overlay (no controllers/monitoring/overrides/lab.yaml),
# so opt out of the base.yaml OTLP export to avoid filter pods retrying
Expand Down
1 change: 0 additions & 1 deletion deployment/openfilter-pipelines-controller/overrides/production.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ image:
tag: "fe613cc832bc53753274fb6e1a178dd8d00d2c33" # {"$imagepolicy": "production:openfilter-pipelines-controller:tag"}
claimerImage:
repository: plainsightai/openfilter-pipelines-claimer
tag: "fe613cc832bc53753274fb6e1a178dd8d00d2c33" # {"$imagepolicy": "production:openfilter-pipelines-controller:tag"}
resources:
requests:
cpu: "100m"
Expand Down
1 change: 0 additions & 1 deletion deployment/openfilter-pipelines-controller/overrides/staging.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ image:
tag: "fe613cc832bc53753274fb6e1a178dd8d00d2c33" # {"$imagepolicy": "staging:openfilter-pipelines-controller:tag"}
claimerImage:
repository: plainsightai/openfilter-pipelines-claimer
tag: "fe613cc832bc53753274fb6e1a178dd8d00d2c33" # {"$imagepolicy": "staging:openfilter-pipelines-controller:tag"}
telemetry:
exporterType: otlp
# Scheme prefix is load-bearing. openfilter ≥ 0.2.1 infers OTLP gRPC TLS
Expand Down
7 changes: 6 additions & 1 deletion deployment/openfilter-pipelines-controller/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,12 @@ spec:
{{- end }}
{{- end }}
- name: CLAIMER_IMAGE
value: "{{ .Values.claimerImage.repository }}:{{ .Values.claimerImage.tag | default .Chart.AppVersion }}"
# Fall through to image.tag when claimerImage.tag is unset so
# ArgoCD Image Updater (which only rewrites image.tag from the
# gitops `image-list` annotation) keeps the controller + claimer
# in lockstep. AppVersion is the last-resort floor for fresh
# installs that haven't been bumped yet.
value: "{{ .Values.claimerImage.repository }}:{{ .Values.claimerImage.tag | default .Values.image.tag | default .Chart.AppVersion }}"
{{- if .Values.gpuNodeSelector }}
- name: GPU_NODE_SELECTOR
value: {{ .Values.gpuNodeSelector | quote }}
Expand Down
Loading