fix(rclone): support dependent remote config sections#63
Draft
feelautom wants to merge 2 commits into
Draft
Conversation
Collaborator
|
Hello, Thanks for the PR. I'll do a proper review during the week. I've just realized that the first commits touch the |
ba7b1aa to
753012b
Compare
753012b to
71e96ed
Compare
Author
|
Thanks for the clarification. I updated the PR to remove the changes touching the obsolete |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes rclone wrapper remotes imported into Plakar when they depend on other rclone config sections.
For example, a
crypt,alias, orchunkerremote can reference another remote such asdrive:bucket. Before this change, the connector installed only the imported wrapper section into rclone's in-memory config, so rclone could not resolve the dependent section and failed with errors such as:Changes
rclone_config_file/rclone_configas connector options instead of passing them to the backend.Validation
plakar store pingsucceeded.plakar at @store createsucceeded.This PR branch intentionally excludes the temporary artifact-build workflow used for local validation, keeping the upstream diff focused on the rclone fix.