Skip to content

Fix Gradio UI freezing when switching tabs #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
neoneye merged 14 commits into from
Apr 10, 2026
+48 −51
Merged

Fix Gradio UI freezing when switching tabs #548

Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
e2411f3
fix: remove browser_state from settings change callbacks
neoneye Apr 10, 2026
7296452
debug: strip Settings tab to bare minimum to isolate hang
neoneye Apr 10, 2026
cc508db
debug: disable gr.Examples to test if it causes the tab hang
neoneye Apr 10, 2026
a013d04
debug: disable ALL settings callbacks and .load handlers
neoneye Apr 10, 2026
c1720a4
debug: re-enable only .load handlers
neoneye Apr 10, 2026
3778e6f
debug: .load only updates session_state, not settings components
neoneye Apr 10, 2026
089b7fc
debug: disable browser_state .load entirely, keep only open_dir .load
neoneye Apr 10, 2026
3398134
debug: disable ALL .load handlers including open_dir
neoneye Apr 10, 2026
be1099a
debug: re-enable only update_open_dir .load handler
neoneye Apr 10, 2026
f07048e
debug: .load with no-op lambda, no outputs
neoneye Apr 10, 2026
1d7f7bd
debug: .load outputs to status_markdown
neoneye Apr 10, 2026
31614e0
debug: use browser_state.change instead of .load for settings init
neoneye Apr 10, 2026
e903a6b
fix: restore all Settings components and callbacks, no .load
neoneye Apr 10, 2026
b487278
fix: hide Open Output Dir button when service is not running
neoneye Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
99 changes: 48 additions & 51 deletions frontend_single_user/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,9 +382,11 @@ def initialize_browser_settings(browser_state, session_state: SessionState):
session_state.speedvsdetail = speedvsdetail
session_state.model_profile = model_profile
profile_markdown = _profile_models_markdown(model_profile)
return openrouter_api_key, model, speedvsdetail, model_profile, profile_markdown, "", browser_state, session_state
open_dir_visible = gr.update(visible=is_open_dir_service_running())
return openrouter_api_key, model, speedvsdetail, model_profile, profile_markdown, "", open_dir_visible, browser_state, session_state

def update_browser_settings_callback(openrouter_api_key, model, speedvsdetail, model_profile, browser_state, session_state: SessionState):
def save_browser_settings_callback(openrouter_api_key, model, speedvsdetail, model_profile, browser_state):
"""Persist current settings to BrowserState. Called on submit/retry, not on every change."""
try:
settings = json.loads(browser_state) if browser_state else {}
except Exception:
Expand All @@ -393,13 +395,7 @@ def update_browser_settings_callback(openrouter_api_key, model, speedvsdetail, m
settings["model_radio"] = model
settings["speedvsdetail_radio"] = speedvsdetail
settings["model_profile_radio"] = model_profile
updated_browser_state = json.dumps(settings)
session_state.openrouter_api_key = openrouter_api_key
session_state.llm_model = model
session_state.speedvsdetail = speedvsdetail
session_state.model_profile = model_profile
profile_markdown = _profile_models_markdown(model_profile)
return updated_browser_state, openrouter_api_key, model, speedvsdetail, model_profile, profile_markdown, "", session_state
return json.dumps(settings)

def run_planner(submit_or_retry_button, plan_prompt, browser_state, session_state: SessionState):
"""
Expand Down Expand Up @@ -765,7 +761,7 @@ def check_api_key(session_state: SessionState):
speedvsdetail_items,
value=SpeedVsDetailEnum.ALL_DETAILS_BUT_SLOW,
label="Speed vs Detail",
interactive=True
interactive=True
)

if CONFIG.visible_llm_info:
Expand All @@ -783,7 +779,7 @@ def check_api_key(session_state: SessionState):
available_model_names,
value=default_model_value,
label="Model",
interactive=True
interactive=True
)

model_profile_radio = gr.Radio(
Expand Down Expand Up @@ -848,6 +844,10 @@ def check_api_key(session_state: SessionState):
fn=clear_status,
inputs=session_state,
outputs=[status_markdown, session_state]
).then(
fn=save_browser_settings_callback,
inputs=[openrouter_api_key_text, model_radio, speedvsdetail_radio, model_profile_radio, browser_state],
outputs=[browser_state]
).then(
fn=run_planner,
inputs=[submit_btn, prompt_input, browser_state, session_state],
Expand All @@ -861,6 +861,10 @@ def check_api_key(session_state: SessionState):
fn=clear_status,
inputs=session_state,
outputs=[status_markdown, session_state]
).then(
fn=save_browser_settings_callback,
inputs=[openrouter_api_key_text, model_radio, speedvsdetail_radio, model_profile_radio, browser_state],
outputs=[browser_state]
).then(
fn=run_planner,
inputs=[retry_btn, prompt_input, browser_state, session_state],
Expand Down Expand Up @@ -888,67 +892,60 @@ def check_api_key(session_state: SessionState):
)
# The download file value is updated by run_planner generator outputs.

# Unified change callbacks for settings.
# Settings change callbacks — update session_state and profile display.
settings_change_inputs = [openrouter_api_key_text, model_radio, speedvsdetail_radio, model_profile_radio, session_state]
settings_change_outputs = [profile_models_markdown, active_config_markdown, session_state]

def update_settings_on_change(openrouter_api_key, model, speedvsdetail, model_profile, session_state: SessionState):
session_state.openrouter_api_key = openrouter_api_key
session_state.llm_model = model
session_state.speedvsdetail = speedvsdetail
session_state.model_profile = model_profile
profile_markdown = _profile_models_markdown(model_profile)
return profile_markdown, "", session_state

openrouter_api_key_text.change(
fn=update_browser_settings_callback,
inputs=[openrouter_api_key_text, model_radio, speedvsdetail_radio, model_profile_radio, browser_state, session_state],
outputs=[browser_state, openrouter_api_key_text, model_radio, speedvsdetail_radio, model_profile_radio, profile_models_markdown, active_config_markdown, session_state]
).then(
fn=check_api_key,
inputs=[session_state],
outputs=[api_key_warning]
)
fn=update_settings_on_change,
inputs=settings_change_inputs,
outputs=settings_change_outputs,
).then(fn=check_api_key, inputs=[session_state], outputs=[api_key_warning])

model_radio.change(
fn=update_browser_settings_callback,
inputs=[openrouter_api_key_text, model_radio, speedvsdetail_radio, model_profile_radio, browser_state, session_state],
outputs=[browser_state, openrouter_api_key_text, model_radio, speedvsdetail_radio, model_profile_radio, profile_models_markdown, active_config_markdown, session_state]
).then(
fn=check_api_key,
inputs=[session_state],
outputs=[api_key_warning]
)
fn=update_settings_on_change,
inputs=settings_change_inputs,
outputs=settings_change_outputs,
).then(fn=check_api_key, inputs=[session_state], outputs=[api_key_warning])

speedvsdetail_radio.change(
fn=update_browser_settings_callback,
inputs=[openrouter_api_key_text, model_radio, speedvsdetail_radio, model_profile_radio, browser_state, session_state],
outputs=[browser_state, openrouter_api_key_text, model_radio, speedvsdetail_radio, model_profile_radio, profile_models_markdown, active_config_markdown, session_state]
).then(
fn=check_api_key,
inputs=[session_state],
outputs=[api_key_warning]
)
fn=update_settings_on_change,
inputs=settings_change_inputs,
outputs=settings_change_outputs,
).then(fn=check_api_key, inputs=[session_state], outputs=[api_key_warning])

model_profile_radio.change(
fn=update_browser_settings_callback,
inputs=[openrouter_api_key_text, model_radio, speedvsdetail_radio, model_profile_radio, browser_state, session_state],
outputs=[browser_state, openrouter_api_key_text, model_radio, speedvsdetail_radio, model_profile_radio, profile_models_markdown, active_config_markdown, session_state]
).then(
fn=check_api_key,
inputs=[session_state],
outputs=[api_key_warning]
)
fn=update_settings_on_change,
inputs=settings_change_inputs,
outputs=settings_change_outputs,
).then(fn=check_api_key, inputs=[session_state], outputs=[api_key_warning])

purge_button.click(
fn=trigger_purge_runs,
inputs=[purge_max_age_hours, session_state],
outputs=[purge_status, session_state]
)

# Initialize settings on load from persistent browser_state.
demo_text2plan.load(
# Restore settings from BrowserState when it loads from localStorage.
# We use browser_state.change instead of demo_text2plan.load because
# Gradio 6.11 has a bug where .load with outputs breaks tab switching.
browser_state.change(
fn=initialize_browser_settings,
inputs=[browser_state, session_state],
outputs=[openrouter_api_key_text, model_radio, speedvsdetail_radio, model_profile_radio, profile_models_markdown, active_config_markdown, browser_state, session_state]
outputs=[openrouter_api_key_text, model_radio, speedvsdetail_radio, model_profile_radio, profile_models_markdown, active_config_markdown, open_dir_btn, browser_state, session_state]
).then(
fn=check_api_key,
inputs=[session_state],
outputs=[api_key_warning]
)
demo_text2plan.load(
fn=update_open_dir_button_visibility,
outputs=[open_dir_btn]
)

def run_app():
# print("Environment variables Gradio:\n" + get_env_as_string() + "\n\n\n")
Expand Down