Challege completed johan-avila@outlook.com#156
Open
johanaggu wants to merge 1 commit intoPlatziMaster:masterfrom
johanaggu:master
Open
Challege completed johan-avila@outlook.com#156johanaggu wants to merge 1 commit intoPlatziMaster:masterfrom johanaggu:master
johanaggu wants to merge 1 commit intoPlatziMaster:masterfrom
johanaggu:master
Conversation
gndx
approved these changes
Jul 24, 2020
| @@ -1,5 +1,6 @@ | |||
| const triangleArea = (base, height) => { | |||
|
|
|||
| let area = (base * height) / 2 | |||
Contributor
There was a problem hiding this comment.
Suggested change
| let area = (base * height) / 2 | |
| let area = (base * height) / 2; |
| const triangleArea = (base, height) => { | ||
|
|
||
| let area = (base * height) / 2 | ||
| return area |
Contributor
There was a problem hiding this comment.
Suggested change
| return area | |
| return area; |
Contributor
There was a problem hiding this comment.
Al estar utilizando una Arrow function no es necesario utilizar el return, puedes utilizar directamente el return de área y el cálculo que deseas realizar.
Author
There was a problem hiding this comment.
Lo trate de hacer así pero al correr el test me arrojaba un "FAIL"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.