Conversation
hyfi06
suggested changes
Apr 24, 2020
src/filter.js
Outdated
Comment on lines
15
to
34
| { | ||
| label: 'Últimos 7 días', | ||
| startAt: format(sub(today, { days: 7 }), dateFormat), | ||
| endAt: format(today, dateFormat) | ||
| }, | ||
| { | ||
| label: 'Últimos 28 días', | ||
| startAt: format(sub(today, { days: 28 }), dateFormat), | ||
| endAt: format(today, dateFormat) | ||
| }, | ||
| { | ||
| label: 'Últimos 90 días', | ||
| startAt: format(sub(today, { days: 90 }), dateFormat), | ||
| endAt: format(today, dateFormat) | ||
| }, | ||
| { | ||
| label: 'Últimos 365 días', | ||
| startAt: format(sub(today, { days: 365 }), dateFormat), | ||
| endAt: format(today, dateFormat) | ||
| } |
There was a problem hiding this comment.
Cuando tienes código similar repetido varias veces es señal de que debes implementar una función o una clase
Author
There was a problem hiding this comment.
Resuelto en el siguiente commit. ¡Gracias!
src/filter.js
Outdated
| const startOfYear = require('date-fns/startOfYear') | ||
| const endOfYear = require('date-fns/endOfYear') | ||
|
|
||
| const makeFilter = (date) => { |
Author
There was a problem hiding this comment.
Resuelto en el siguiente commit. ¡Gracias!
src/filter.js
Outdated
| const makeFilter = (date) => { | ||
| let filters = []; | ||
|
|
||
| const today = new Date(2020,0,1); |
There was a problem hiding this comment.
No tienes que quemar el valor de la fecha, lo recibes como parámetro.
Author
There was a problem hiding this comment.
Resuelto en el siguiente commit. ¡Gracias!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completed the makeFilter function