Conversation
hyfi06
suggested changes
Apr 26, 2020
| ] | ||
|
|
||
| def is_homeless(dev): | ||
| dev.update( { 'homeless': dev['organization'] == '' } ) |
There was a problem hiding this comment.
dev pasa por referencia, por lo que al aplicar update se modifica en DATA también. Necesitas regresar un nuevo diccionario con la modificación para no afectar tus datos de entrada.
| workers = map(is_homeless , DATA) | ||
|
|
||
| # Using map, generate a new list of people with a key 'old' with True or False values, if 'age' is greater than 30 or not | ||
| old_people = map(is_old, DATA) |
There was a problem hiding this comment.
Los elementos de old_people tiene la propiedad homeless por que fueron alterados antes.
| return dev | ||
|
|
||
| def is_old(dev): | ||
| dev.update( { 'old': dev['age'] > 30 } ) |
There was a problem hiding this comment.
Aquí también deberías de hacer un nuevo diccionario.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i'm tired but happy