Overall improvement of the Republisher Dialog (sorting, filters, better selection process)#108
Open
guilyx wants to merge 13 commits intoPlotJuggler:mainfrom
Open
Overall improvement of the Republisher Dialog (sorting, filters, better selection process)#108guilyx wants to merge 13 commits intoPlotJuggler:mainfrom
guilyx wants to merge 13 commits intoPlotJuggler:mainfrom
Conversation
Contributor
|
also, the formatting changes make the PR much harder to review. But that is not some, really. I will add clang-format and pre-commit to prevent that, but please be more considerate in the future. |
Contributor
|
added proper formatting and check. Please fix conflict and reformat using pre-commit |
d6a03f2 to
6b3fbd0
Compare
Author
|
@facontidavide should be ready for review now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @facontidavide, coming with some overall improvement (UX improvements) for the republisher plugin:
Problem(s):
Solution(s)
Changes
Alphabetical Sorting:
Filter Functionality
UI Improvements
Code Quality
Replaced deprecated foreach with C++11 range-based for loops
Note: void TopicPublisherROS2::broadcastTF(double current_time) was reformatted for consistency
Screenshots
From:
To: