Skip to content

Reservation v2 & onboarding & Allergens in menu#144

Open
yohann69 wants to merge 29 commits intomasterfrom
reservation-v2-&-onboarding
Open

Reservation v2 & onboarding & Allergens in menu#144
yohann69 wants to merge 29 commits intomasterfrom
reservation-v2-&-onboarding

Conversation

@yohann69
Copy link
Member

@yohann69 yohann69 commented Jan 13, 2026

Reservation -> suppoort d'un message de resevation et confirmation de résa custom
Onboarding
Allergens for the menu
Améliorations diverses

Updated club details and related components to handle multiple responsibles instead of a single responsible. The ClubResponsible component now accepts an array of users, and the club DTO and filtering logic have been updated for backward compatibility and to support searching by multiple responsibles.
Introduces optional warningMessage and confirmationMessage props to ReservationDialog, ReservationCard, and ReservationList components. Updates DTO schemas and transformation utilities to support these fields, allowing custom messages to be displayed in reservation dialogs.

This comment was marked as outdated.

Copy link
Collaborator

@HeineZo HeineZo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il y a aussi plusieurs erreurs typescript à travers l'app, souvent des imports inutilisés, il faudrait les corrigés

Comment on lines +43 to +47
// Handle skipping a single step (not the entire onboarding)
const handleSkipStep = () => {
// This will be handled by each screen individually
// They will navigate to the next step or preview
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ils peuvent pas skip ?

Comment on lines +76 to +79
// The mutation already fetches fresh user data, but let's refetch to be sure
if (refetch) {
try {
const freshUser = await refetch();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pourquoi est-ce qu'il y a besoin de faire ça ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pour mettre à jour à coup sur l'utilisateur quand tu mets à jour ses infos dans l'onboarding

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tu n'utilises pas tanstack query ?

yohann69 and others added 12 commits January 14, 2026 11:21
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Remove onboarding encouragement texts and refactor navigation

Removed 'encouragement' and preview 'title' fields from onboarding translations in all supported languages for a cleaner UI. Refactored OnboardingNavigator to set onboarding as skipped when a step is skipped and improved initial route logic readability. Also removed console.log statements from RootNavigator for cleaner production logs.
@yohann69 yohann69 requested a review from Copilot January 14, 2026 11:31

This comment was marked as outdated.

yohann69 and others added 4 commits January 14, 2026 13:37
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@yohann69 yohann69 requested review from HeineZo and Copilot January 15, 2026 08:47
@yohann69 yohann69 changed the title Reservation v2 & onboarding Reservation v2 & onboarding & Allergens in menu Jan 15, 2026

This comment was marked as outdated.

Deleted the 'exemple_restaurant_page.html' file as it is no longer needed in the project.
Added force show onboarding logic to ensure new users start from the ProfilePicture step. Enhanced step detection to treat empty strings as missing for profile picture, basic info, and phone number fields. Introduced getForceShowOnboarding utility for consistent onboarding state management.

This comment was marked as outdated.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enlever les svg

@HeineZo
Copy link
Collaborator

HeineZo commented Jan 20, 2026

je suis chaud que tu mette des screens des modifications que t'as apportés

@yohann69
Copy link
Member Author

je suis chaud que tu mette des screens des modifications que t'as apportés

image image image (y a plus event vides) image image image image

Removed unused useOnboardingSteps import and variable from RootNavigator. Cleaned up comments in OnboardingPreview. Simplified getForceShowOnboarding to return a boolean directly.
Changed the color for phone number, graduation year, and profile picture fields in OnboardingPreview to use theme.secondary instead of primary, success, and warning. Also updated app version to 2.2.5 in app.json.
Enhances error handling in apiRequest to preserve Axios error details, including status codes and network error flags. Updates useAuthMutations to only log out users on 401 errors, allowing network errors to retain session and retry up to 3 times, improving offline and error resilience.
Refactored error handling in api-request.ts and useAuthMutations.ts for better readability and consistent formatting, especially in ternary expressions and multi-line error messages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants