Reservation v2 & onboarding & Allergens in menu#144
Open
Reservation v2 & onboarding & Allergens in menu#144
Conversation
Updated club details and related components to handle multiple responsibles instead of a single responsible. The ClubResponsible component now accepts an array of users, and the club DTO and filtering logic have been updated for backward compatibility and to support searching by multiple responsibles.
Introduces optional warningMessage and confirmationMessage props to ReservationDialog, ReservationCard, and ReservationList components. Updates DTO schemas and transformation utilities to support these fields, allowing custom messages to be displayed in reservation dialogs.
HeineZo
reviewed
Jan 13, 2026
Collaborator
HeineZo
left a comment
There was a problem hiding this comment.
Il y a aussi plusieurs erreurs typescript à travers l'app, souvent des imports inutilisés, il faudrait les corrigés
Comment on lines
+43
to
+47
| // Handle skipping a single step (not the entire onboarding) | ||
| const handleSkipStep = () => { | ||
| // This will be handled by each screen individually | ||
| // They will navigate to the next step or preview | ||
| }; |
Comment on lines
+76
to
+79
| // The mutation already fetches fresh user data, but let's refetch to be sure | ||
| if (refetch) { | ||
| try { | ||
| const freshUser = await refetch(); |
Collaborator
There was a problem hiding this comment.
pourquoi est-ce qu'il y a besoin de faire ça ?
Member
Author
There was a problem hiding this comment.
Pour mettre à jour à coup sur l'utilisateur quand tu mets à jour ses infos dans l'onboarding
Collaborator
There was a problem hiding this comment.
tu n'utilises pas tanstack query ?
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Remove onboarding encouragement texts and refactor navigation Removed 'encouragement' and preview 'title' fields from onboarding translations in all supported languages for a cleaner UI. Refactored OnboardingNavigator to set onboarding as skipped when a step is skipped and improved initial route logic readability. Also removed console.log statements from RootNavigator for cleaner production logs.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Deleted the 'exemple_restaurant_page.html' file as it is no longer needed in the project.
Added force show onboarding logic to ensure new users start from the ProfilePicture step. Enhanced step detection to treat empty strings as missing for profile picture, basic info, and phone number fields. Introduced getForceShowOnboarding utility for consistent onboarding state management.
HeineZo
reviewed
Jan 20, 2026
src/app/screens/services/restaurant/components/Reviews/AllergenDialog.tsx
Show resolved
Hide resolved
Collaborator
|
je suis chaud que tu mette des screens des modifications que t'as apportés |
Member
Author
Removed unused useOnboardingSteps import and variable from RootNavigator. Cleaned up comments in OnboardingPreview. Simplified getForceShowOnboarding to return a boolean directly.
Changed the color for phone number, graduation year, and profile picture fields in OnboardingPreview to use theme.secondary instead of primary, success, and warning. Also updated app version to 2.2.5 in app.json.
Enhances error handling in apiRequest to preserve Axios error details, including status codes and network error flags. Updates useAuthMutations to only log out users on 401 errors, allowing network errors to retain session and retry up to 3 times, improving offline and error resilience.
Refactored error handling in api-request.ts and useAuthMutations.ts for better readability and consistent formatting, especially in ternary expressions and multi-line error messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.







Reservation -> suppoort d'un message de resevation et confirmation de résa custom
Onboarding
Allergens for the menu
Améliorations diverses