Fix compilation errors with modern ROOT and c++#3
Fix compilation errors with modern ROOT and c++#3rlalik wants to merge 2 commits intoPlutoUser:masterfrom
Conversation
|
there are some conflicts with the version from GSI Gitlab, could you resolve this? |
|
Can you show me what conflicts are there? I added another improvements which detects root < 6.22 (version where the significant change happen) and perhaps this will fix the issue? |
|
Ok, I see that there was another fix by Jochen, which was not merged apparently when I made the fork. So now my fix conflicts with his. Perhaps this must be abandon then. |
|
We have several ROOT versions (and more to come), I think the solution to use an #if-#elif-#else consstuction is the best way |
|
what about this merge, is it still to be merged or should it be closed? |
|
The fix in other commit which fixed the issue is in conflict with this merge. Those are two different approaches, one could check which one would work better. One can keep this still open for future work but now please check the other PR because the are more urgent. |
fParamsofTF1Paramsis now ofstd::unique_ptrtype, not raw pointer. Thus I fixed that. Sincestd::make_uniqueis not available in c++11 I addedd a simle implementation in a pluto private header.While saving files some trailing whitespaces were removed.