Fix network speed test TLS, cert bypass, and status reporting#23
Merged
Conversation
- Enable TLS 1.2/1.3 additively before each download (per-protocol try/catch so it won't throw on older .NET), restored in finally. - Add -SkipCertificateCheck on PowerShell 7+, where HttpClient ignores the ServicePointManager cert callback used for VPN/proxy MITM. - Reset $status to SUCCESS on a successful download so an earlier Get-NetAdapter failure no longer mislabels a working test as FAILED. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three issues in
Test-NetworkSpeed(SystemTester.ps1) that could cause the internet download test to fail or be mislabeled.Changes
try/catch(Tls13 throws on pre-.NET 4.8 runtimes) and the priorSecurityProtocolis restored infinally.-SkipCertificateCheckon PowerShell 7+. On PS 7+,Invoke-WebRequestusesHttpClient, which ignores theServicePointManagercert callback used to handle VPN/proxy TLS interception (Mullvad, Tailscale, etc.). The callback alone was a no-op there.$statustoSUCCESSafter a good download. If the earlierGet-NetAdapterquery threw,$statuswas set toFAILEDand never cleared, so a working speed test was recorded asFAILED. All four adapter/download outcome permutations now resolve correctly.Notes
🤖 Generated with Claude Code