Questionnaire: Drag and Drop "Sorting" question by lamtranb · Pull Request #440 · PoetOS/moodle-mod_questionnaire

lamtranb · 2022-12-09T09:51:24Z

Hi,

We are from the Open University and would like to do this change:

Create a new question type Drag and Drop "Sorting".

Could you please review this commit and inform for any issue?

Thanks.

lamtranb · 2023-01-06T13:06:26Z

Hi @mchurchward

I have rebased the code. Could you review this PR?

Thanks.

mchurchward

Hi. Thanks for this... some review comments:

Is the new response table necessary? It looks like it could use the standard "questionnaire_response_text" table.
What is the purpose of the new "mobile_questionnaire_init" function in the mobile.php class?
Can you explain the changes made to "db/mobile.php"?
It appears you have replaced the "styles_app.css" with the new "mobile_css.php" file. Given that, should the "styles_app.css" be deleted?
Can the "questionnaire_prep_answer_sort_question" function in locallib be refactored into one of the classes? Maybe the specific response class?
Can you add the new question type to the unit test for csv exporting?

lamtranb · 2023-03-22T11:56:18Z

Hi @mchurchward,

I updated the code.

Is the new response table necessary? It looks like it could use the standard "questionnaire_response_text" table.

Yes, because we store a string example "1,2,3" which are sorting choices. And later we can transform it into array, so it has different behavior from questionnaire_response_text.

What is the purpose of the new "mobile_questionnaire_init" function in the mobile.php class?

This is used for mobile app. It called the JS file: appjs/latest/mobile_view_activity.js. And sadly, we did not support for ionic 3 yet.

Can you explain the changes made to "db/mobile.php"?

The changes we made in this file is we called the PHP method mobile_questionnaire_init (point 2).

It appears you have replaced the "styles_app.css" with the new "mobile_css.php" file. Given that, should the "styles_app.css" be deleted?

Thanks for correct me. I added some code into styles_app.css and removed mobile.css.

Can the "questionnaire_prep_answer_sort_question" function in locallib be refactored into one of the classes? Maybe the specific response class?

Thanks for your suggestion. I moved all sort methods from locallib to responsetype\sorting.

Can you add the new question type to the unit test for csv exporting?

Of course. I added some UTs.

Could you please review the code again?

Many thanks

rezeau · 2023-08-02T16:43:52Z

Cannot test and review because this PR must be re-based against current MOODLE_400_STABLE first.

…s. (PoetOS#449) * Resized the monologo.svg and png to 24x24 px (PoetOS#477) * Fixing issues from plugins database checks (PoetOS#483) * Removing illegal console commands. Script may not be needed. * Fixing illegal line length. * Fixing docblocks and unused variables. * Fixing css spaces. * Adding a true return. * Fixing JSON context. * Allow localized answer options to be displayed correctly in conditions. --------- Co-authored-by: FelixDiLenarda <92793568+FelixDiLenarda@users.noreply.github.com> Co-authored-by: Mike Churchward <mike.churchward@poetopensource.org>

* The text editor should be programmatically associated with the question Co-authored-by: toanlam <toanlamt1@nashtechglobal.com>

…iated with the labels and the slider should be programmatically associated with the question (PoetOS#495) * Questionnaire: More meaningful error than nopermissions (PoetOS#488) Co-authored-by: Emanoil Manoylov <em22699@open.ac.uk> * Questionnaire\Accessibility\Slider: The slider values should be associated with the labels #674064 --------- Co-authored-by: emanoylov <80328987+emanoylov@users.noreply.github.com> Co-authored-by: Emanoil Manoylov <em22699@open.ac.uk> Co-authored-by: tai.letan <tlt84@open.ac.uk>

…lly associated caption (PoetOS#497) * Questionnaire: More meaningful error than nopermissions (PoetOS#488) Co-authored-by: Emanoil Manoylov <em22699@open.ac.uk> * Questionnaire\Accessibility\Rate: table does not have a programmatically associated caption --------- Co-authored-by: emanoylov <80328987+emanoylov@users.noreply.github.com> Co-authored-by: Emanoil Manoylov <em22699@open.ac.uk> Co-authored-by: lamtranb <ltb58@open.ac.uk>

…y associated with field #672028 (PoetOS#496) Co-authored-by: tai.letan <tlt84@open.ac.uk>

tailetan · 2023-09-22T03:51:58Z

I have already rebased this with MOODLE_401_STABLE.
FYI: @rezeau, @mchurchward

mchurchward · 2023-09-26T15:13:06Z

For whatever reason, there are still merge conflicts that need to be resolved. This is usually due to needing rebasing.

…are not accessible (PoetOS#505) Co-authored-by: lamtranb <ltb58@open.ac.uk>

) Co-authored-by: Emanoil Manoylov <em22699@open.ac.uk>

* now using core_external\external_api - fixes PoetOS#502 * using valid $required parameter VALUE_REQUIRED - fixes PoetOS#507 --------- Co-authored-by: Matthias Opitz <m.opitz@ucl.ac.uk>

tailetan · 2023-10-05T08:11:56Z

I have already rebased this with MOODLE_401_STABLE.
FYI: @mchurchward

lamtranb · 2023-10-21T02:59:30Z

Dear @tailetan , this branch has conflicts again. Could you please resolve it?

tailetan · 2023-10-21T04:16:32Z

@lamtranb, I've just rebased the latest code. Thank you

mchurchward force-pushed the main branch from 541329a to f976c8e Compare December 21, 2022 00:31

mchurchward changed the base branch from main to MOODLE_400_STABLE December 21, 2022 14:50

lamtranb force-pushed the wip323936 branch 2 times, most recently from 6556148 to 9fdb422 Compare January 1, 2023 12:51

mchurchward self-requested a review January 30, 2023 18:47

mchurchward reviewed Jan 30, 2023

View reviewed changes

lamtranb force-pushed the wip323936 branch 10 times, most recently from a5ff9a1 to f2591b0 Compare February 27, 2023 07:22

lamtranb force-pushed the wip323936 branch from f2591b0 to 2f41b65 Compare March 8, 2023 07:00

lamtranb force-pushed the wip323936 branch 12 times, most recently from c3b22b7 to e6f0e4d Compare March 22, 2023 11:48

mchurchward and others added 7 commits August 11, 2023 11:46

Setting up release for Moodle 4.1 onward.

686880b

Questionnaire: improved accessibility for essay box type (PoetOS#506)

133f4c7

* The text editor should be programmatically associated with the question Co-authored-by: toanlam <toanlamt1@nashtechglobal.com>

Removing 4.3 for now.

64457dd

Questionnaire\Accessibility\Numeric: Instructions not programmaticall…

cb07cc2

…y associated with field #672028 (PoetOS#496) Co-authored-by: tai.letan <tlt84@open.ac.uk>

tailetan force-pushed the wip323936 branch from e6f0e4d to 5715134 Compare September 22, 2023 03:27

tailetan force-pushed the wip323936 branch from 5715134 to 0eb4d0e Compare September 22, 2023 04:02

lamtranb and others added 3 commits September 26, 2023 11:14

Questionnaire\Accessibility\Rate: The form controls within the table …

3813cba

…are not accessible (PoetOS#505) Co-authored-by: lamtranb <ltb58@open.ac.uk>

Questionnaire/Accessibility: Check boxes missing group label (PoetOS#501

829c180

) Co-authored-by: Emanoil Manoylov <em22699@open.ac.uk>

Fixing issues PoetOS#502 and PoetOS#507 (PoetOS#508)

04023c2

* now using core_external\external_api - fixes PoetOS#502 * using valid $required parameter VALUE_REQUIRED - fixes PoetOS#507 --------- Co-authored-by: Matthias Opitz <m.opitz@ucl.ac.uk>

tailetan force-pushed the wip323936 branch from 0eb4d0e to 736066b Compare October 5, 2023 06:40

Adding Moodle 4.3beta to the mix.

57ba67f

Questionnaire: Drag and Drop "Sorting" question #323936

92a1dd8

tailetan force-pushed the wip323936 branch from eb8056d to 92a1dd8 Compare October 21, 2023 03:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Questionnaire: Drag and Drop "Sorting" question#440

Questionnaire: Drag and Drop "Sorting" question#440
lamtranb wants to merge 12 commits into
PoetOS:MOODLE_400_STABLEfrom
NashTechOpenUniversity:wip323936

lamtranb commented Dec 9, 2022

Uh oh!

lamtranb commented Jan 6, 2023

Uh oh!

mchurchward left a comment

Uh oh!

lamtranb commented Mar 22, 2023

Uh oh!

rezeau commented Aug 2, 2023

Uh oh!

tailetan commented Sep 22, 2023

Uh oh!

mchurchward commented Sep 26, 2023

Uh oh!

tailetan commented Oct 5, 2023

Uh oh!

lamtranb commented Oct 21, 2023

Uh oh!

tailetan commented Oct 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

lamtranb commented Dec 9, 2022

Uh oh!

lamtranb commented Jan 6, 2023

Uh oh!

mchurchward left a comment

Choose a reason for hiding this comment

Uh oh!

lamtranb commented Mar 22, 2023

Uh oh!

rezeau commented Aug 2, 2023

Uh oh!

tailetan commented Sep 22, 2023

Uh oh!

mchurchward commented Sep 26, 2023

Uh oh!

tailetan commented Oct 5, 2023

Uh oh!

lamtranb commented Oct 21, 2023

Uh oh!

tailetan commented Oct 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants