Detect button::BODY_OUTLINE reliably.#700
Open
lucaboesch wants to merge 1 commit into
Open
Conversation
lucaboesch
force-pushed
the
activitiespage
branch
from
b9803e4 to
09e72b5
Compare
lucaboesch
force-pushed
the
activitiespage
branch
from
09e72b5 to
d2d1696
Compare
mchurchward
force-pushed
the
MOODLE_500_STABLE
branch
from
bf6222b to
4ce82ef
Compare
lucaboesch
force-pushed
the
activitiespage
branch
from
d2d1696 to
2821c51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The class of the activity overview page should be of class button::BODY_OUTLINE where it exists (Moodle ≥ 5.1) and of btn btn-outline-secondary (corrisponding to button::BODY_SECONDARY) where it does not exist (Moodle ≤ 5.0).
Additionally, @mchurchward, this lets the tests for Moodle 5.2 (main) pass.
The "Activities" block has been removed in the next (to be released 20th of April) Moodle version.
Thanks!