batch update #1: index, about, navbar, global styles#1
Open
StraubCreative wants to merge 1 commit into
Open
Conversation
Contributor
|
• I really like the search function on in the jumbotron, I think it's a nice touch. That being said, I think the white background of the text doesn't contrast very much with the jumbotron, and maybe could be retouched. • Is there any way to get spacing between the deleted tweets? • I've always put icons before the text — you're welcome to do otherwise, but it seems a bit strange to me. • The search bar could use a bit of touching up. On my computer it looks a bit big and bulky. Definitely a step in the right direction! I like the search function. Great work here. I don't think it'd be best to merge into master at this point (all the backend stuff hasn't been changed to support the changes yet), so could we continue to work in this branch? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
5.22.17
global
/index
/about
Bugs, future features and chores listed under Projects