fix icon streamer#41
Open
tomvita wants to merge 1 commit into
Open
Conversation
Owner
|
Hi, I already fixed it so I don't think it's a great idea. what do you think ? |
Author
|
There are many ways to fix this problem, just wanted to share what I did. By the way taking over eshop don't work on HOS 22. Just move it to another applet and the crash stops. |
Owner
|
I'll do that. But why taking over eshop doesn't work now? I didn't see something about eshop in 22 changelog |
Author
|
You can try put something else there and it will crash too. Your home menu can sit there as long as you don't call it though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happens:
The fix (lines 175-187):
After reserve(), compare m_pool.data() before and after. If the pool was relocated, iterate all pool slots and re-wire the Texture* pointer on every surviving GlossyIcon. This is O(pool_size) and only runs when an actual reallocation occurs, so there's negligible performance impact.