Merged
Conversation
vjaganat90
force-pushed
the
dev4
branch
2 times, most recently
from
1403a8e to
eb96f5e
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds a new test for the VolumeGenerator functionality and updates the test data repository structure to organize image files into 2D and 3D subdirectories.
Changes:
- Added
test_volume_generator.pywith a parameterized test that validates volume generation output - Updated existing tests to reference the new
2Dsubdirectory structure in the test data repository - Enhanced the git clone command to explicitly specify branch and use single-branch clone
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/python/test_volume_generator.py | New test file validating VolumeGenerator creates proper zarr output structure |
| tests/python/test_single_image.py | Updated test data path to include 2D subdirectory |
| tests/python/multi_images.py | Updated test data path to include 2D subdirectory |
| tests/python/io_utils.py | Added branch specification to git clone and introduced double-slash typo in repo URL |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @dataclass(frozen=True) | ||
| class PolusTestDataRepo: | ||
| repo_url: str = "https://github.com/sameeul/polus-test-data.git" | ||
| repo_url: str = "https://github.com/sameeul//polus-test-data.git" |
There was a problem hiding this comment.
The URL contains a double slash ('//') between the username and repository name. This should be a single slash: 'https://github.com/sameeul/polus-test-data.git'.
Suggested change
| repo_url: str = "https://github.com/sameeul//polus-test-data.git" | |
| repo_url: str = "https://github.com/sameeul/polus-test-data.git" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.