Skip to content

Fix failing edge cases test #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PolyMeilex merged 1 commit into from
Mar 6, 2026
Merged

Fix failing edge cases test #370

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion neothesia/src/scene/freeplay/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,10 @@ impl Scene for FreeplayScene {
mod chords {
/// Get chord name based on notes, eg. Cmaj7
pub fn deduce_name(midi_notes: &[u8]) -> String {
if midi_notes.is_empty() {
return "No notes".to_string();
}

if midi_notes.len() == 1 {
return note_name(midi_notes[0]).to_string();
}
Expand Down Expand Up @@ -343,7 +347,7 @@ mod chords {
#[test]
fn test_edge_cases() {
assert_eq!(deduce_name(&[]), "No notes");
assert_eq!(deduce_name(&[60]), "single");
assert_eq!(deduce_name(&[60]), "C");
// Multiple octaves should normalize
assert_eq!(deduce_name(&[48, 64, 67, 72]), "CM");
}
Expand Down