Polyscript config#110
Merged
Merged
Conversation
Contributor
|
Uhh we dont use |
Contributor
Author
oh bruh I will fix now |
IExploitableMan
requested changes
Aug 18, 2025
| namespace PolyMod.Managers; | ||
|
|
||
| /// <summary> | ||
| /// allows mods to save config. |
Contributor
There was a problem hiding this comment.
Capital letters consistency plz 🙏
IExploitableMan
requested changes
Aug 18, 2025
Contributor
IExploitableMan
left a comment
IExploitableMan
left a comment
There was a problem hiding this comment.
ALSO UNDERSCORES!
Contributor
|
I apologize for the stupid small fixes, I can fix it myself when I come home |
Contributor
Author
|
Added gld config as well |
Contributor
Author
|
Closes #107 |
johnklipi
reviewed
Aug 20, 2025
| { | ||
| } | ||
| } | ||
| public abstract class PolyScriptMod<TConfig, TExposedConfig> : PolyScriptModBase where TConfig : class where TExposedConfig : class |
Contributor
There was a problem hiding this comment.
Maybe just call it PolyScript? PolyScript is just a part of the mod.
johnklipi
reviewed
Aug 24, 2025
| protected ManualLogSource Logger { get; private set; } = null!; | ||
| } | ||
|
|
||
| public abstract class PolyScriptMod : PolyScriptMod<JObject, JObject> |
Contributor
There was a problem hiding this comment.
same here, PolyScriptMod -> PolyScript
Contributor
|
@joukepouke @IExploitableMan aside what i commented, LGTM. Was everything properly tested? |
Contributor
|
Capital letters in doc strings |
Contributor
Author
|
@IExploitableMan shall i merge? |
# Conflicts: # src/Loader.cs
This reverts commit c5154ec.
incomplete-tree
force-pushed
the
polyscript-config
branch
from
59ae426 to
1788148
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1/2 of #107