This repository was archived by the owner on May 25, 2026. It is now read-only.
refactor: add specific type hints for all side: str#313
Open
RecRanger wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Description
Add specific type hints for all
side: str. Generally, they areside: Literal["BUY", "SELL"]Types of changes
Notes
Status
[WIP]if necessary (changes not yet made).Note
Low Risk
Low risk refactor limited to type annotations; runtime behavior is unchanged, though stricter typing may surface downstream mypy/IDE warnings where non-supported
sidestrings are passed.Overview
Tightens type hints across the client, order builder, and RFQ types by replacing generic
side: strparameters withLiteral["BUY", "SELL"](and""where optional) to make valid order sides explicit.Updates affected function signatures and dataclass fields (e.g.,
OrderArgs,MarketOrderArgs,BookParams, RFQ user inputs, andcalculate_market_price) and adds the necessaryLiteralimports.Written by Cursor Bugbot for commit 83edd53. This will update automatically on new commits. Configure here.