This repository was archived by the owner on May 25, 2026. It is now read-only.
fix: use is not None to check neg_risk option value#322
Open
maraple8 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fix bug where
neg_risk=Falseincorrectly triggers a call toget_neg_risk(), causing unnecessary network requests.Description
In
create_orderandcreate_market_ordermethods, the original code used truthiness check onoptions.neg_risk. Whenneg_risk=False, the condition evaluates to falsy, incorrectly falling through to callget_neg_risk(). Fixed by usingis not Nonecheck to explicitly distinguish between "not set" and "set to False".Testing instructions
don't need
Types of changes
Notes
py_clob_client/client.pylines 519 and 574neg_risk=Falsetriggers network callneg_risk=Falseuses the value directly without callingget_neg_risk()Status
[WIP]if necessary (changes not yet made).Note
Low Risk
Low risk behavior fix limited to order creation option handling; it only changes how
neg_risk=Falseis interpreted to avoid an unnecessaryget_neg_risk()network call.Overview
Fixes
create_orderandcreate_market_orderso an explicitly providedoptions.neg_risk=Falseis honored.The truthiness check is replaced with an
is not Noneguard, preventing unintended fallback toget_neg_risk()and eliminating unnecessary network requests whenneg_riskis set toFalse.Written by Cursor Bugbot for commit 45e3481. This will update automatically on new commits. Configure here.