feat(client): add combo market catalog#87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Note
Low Risk
Additive public API and transport wiring; keyset pagination changes are backward-compatible defaults for existing gamma endpoints.
Overview
Adds RFQ REST support so clients can browse the Combo market catalog via a new keyset-paginated
list_combo_marketsAPI (optionalexcludefilter), wired through sync/async public and secure clients.Introduces an
rfqHTTP transport (environment.rfq_url), extends dispatch/context with service"rfq", and exportsComboMarketmodels that normalize binary yes/no outcomes from either structured or paralleloutcomes/position_ids/outcome_priceswire shapes.Keyset pagination is generalized with per-spec
cursor_param(RFQ usescursorinstead ofafter_cursor) and optionalmax_page_sizeenforcement (100 for combo markets). Public exports and unit/integration tests cover models, specs, and live pagination.Reviewed by Cursor Bugbot for commit 3839713. Bugbot is set up for automated code reviews on this repo. Configure here.