fix(rfq): parse submission window rejections#89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
COMPETITION_WINDOW_CLOSEDenum value withSUBMISSION_WINDOW_CLOSED.Verification
uv run ruff check .uv run pyrightNote
Low Risk
Single enum member rename in public RFQ types; no logic changes beyond matching the API error string.
Overview
Updates
RfqErrorCodeinrfq.pyby removingCOMPETITION_WINDOW_CLOSEDand addingSUBMISSION_WINDOW_CLOSEDso RFQ quote rejections from the API match the enum used in_parse_error_code(viaRfqErrorCode(value)).Without this rename, submission-window rejections would surface as unknown error codes instead of typed
RfqQuoteRejectedError(or related) with a recognizedcode.Reviewed by Cursor Bugbot for commit ba1b8e9. Bugbot is set up for automated code reviews on this repo. Configure here.