Skip to content

fix(rfq): parse submission window rejections#89

Merged
cesarenaldi merged 1 commit into
mainfrom
fix/rfq-submission-window-code
Jun 10, 2026
Merged

fix(rfq): parse submission window rejections#89
cesarenaldi merged 1 commit into
mainfrom
fix/rfq-submission-window-code

Conversation

@cesarenaldi

@cesarenaldi cesarenaldi commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Replace the stale RFQ COMPETITION_WINDOW_CLOSED enum value with SUBMISSION_WINDOW_CLOSED.
  • Allows RFQ error parsing to accept submission-window quote rejections.

Verification

  • uv run ruff check .
  • uv run pyright

Note

Low Risk
Single enum member rename in public RFQ types; no logic changes beyond matching the API error string.

Overview
Updates RfqErrorCode in rfq.py by removing COMPETITION_WINDOW_CLOSED and adding SUBMISSION_WINDOW_CLOSED so RFQ quote rejections from the API match the enum used in _parse_error_code (via RfqErrorCode(value)).

Without this rename, submission-window rejections would surface as unknown error codes instead of typed RfqQuoteRejectedError (or related) with a recognized code.

Reviewed by Cursor Bugbot for commit ba1b8e9. Bugbot is set up for automated code reviews on this repo. Configure here.

@cesarenaldi cesarenaldi merged commit f101d69 into main Jun 10, 2026
7 checks passed
@cesarenaldi cesarenaldi deleted the fix/rfq-submission-window-code branch June 10, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant