fix(models): expose missing activity market icons as None#94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sparse historical activity rows come back with an empty-string
icon. The strict activity models (TradeActivityand the split/merge/redeem/conversion variants) currently surface that""as-is, while the TypeScript SDK exposes missing icons asnull.This aligns the contract:
iconis nowstr | Noneon the strict activity models, and empty-string icons are normalized toNoneduring activity payload normalization (same sentinel handling already used forconditionId/asset/side/outcome).Note: the API serializes
iconas a string and never emitsnull(verified against the payload source and live responses), so this is a parity/ergonomics fix rather than a parse-failure fix.Verification
icon: ""parse withicon is None.uv run pytest tests/unit -q: 1698 passed.uv run ruff check .,uv run ruff format --check .: clean.uv run pyright: 0 errors.None, populated icons unchanged.Note
Low Risk
Small model and normalization change for an optional display field; no auth, payments, or persistence logic.
Overview
Activity
iconparity with the TypeScript SDK: sparse API rows sendiconas"".TradeActivityand market-event activities (Split,Merge,Redeem,Conversion) now typeiconasstr | None(defaultNone) instead of requiredstr.Normalization:
_normalize_activity_payloadtreats emptyiconlike other sentinels (conditionId,asset, etc.)—the key is dropped so parsing yieldsNonerather than"".Unit tests cover TRADE and SPLIT payloads with
icon: "".Reviewed by Cursor Bugbot for commit b36b41f. Bugbot is set up for automated code reviews on this repo. Configure here.