feat(bindings): expose parentEventId on Event#125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The wire schema already parsed
parentEventIdbutnormalizeEventdropped it, so the publicEventnever exposed it. Sports "more markets" events carry this field as a link to their parent game event.Event.parentEventId?: EventId | null, top-level next toid.EventIdSchemaso the value is the same brandedEventIdtype asEvent.idand feeds directly intofetchEvent({ id: child.parentEventId }).Not in scope: the
listEventsparentEventIdrequest filter still only accepts a number, same as the other ID filters (ids,seriesIds). Aligning the filter inputs with branded string IDs is a broader consistency change worth a separate pass.Verification
pnpm lint,pnpm build,pnpm typecheckpass.pnpm test:types,pnpm test:bindings(15),pnpm test:client(123) pass.EventIdnormalization and absent/null defaults (the regression here was the normalizer silently dropping the field).fetchEvent({ id: '570555' })returnsparentEventId === '570146', round-trips viafetchEvent({ id: child.parentEventId }), and the parent's ownparentEventIdis undefined.Note
Low Risk
Additive, read-only API surface on event parsing with targeted tests; no auth or write-path changes.
Overview
Exposes
parentEventIdon the publicEventtype so child events (e.g. sports “more markets”) can reference their parent. The Gamma wire field was already parsed butnormalizeEventnow forwards it instead of dropping it.parentEventIdis typed and parsed asEventId, matchingEvent.id: wire integers are normalized to string IDs viaEventIdSchema(replacing a rawnumberon the schema). New bindings tests cover int→string normalization and absent/null handling.Reviewed by Cursor Bugbot for commit 1903b61. Bugbot is set up for automated code reviews on this repo. Configure here.