fix(client): split rejected RPC batches#134
Open
cesarenaldi wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eth_callbatches by recursively splitting them into parallel half-size batches.ethCallwhen splitting reaches one request.Verification
pnpm vitest --project client packages/client/src/rpc.test.ts --runpnpm vitest --project client-integration packages/client/tests/integration/approvals.test.ts --run -t "submits a combined trading-setup approval workflow"pnpm lintpnpm typecheckAlso attempted the full client integration suite; it did not complete cleanly because live services returned rate limits, geoblock responses, and request timeouts unrelated to this change.
Note
Medium Risk
Changes batch RPC failure handling for all multi-call reads (e.g. large approval checks), increasing request volume on 5xx but only for transport/server errors.
Overview
ethCallBatchnow retries when the JSON-RPC batch POST fails with a 5xxRequestRejectedError, instead of failing the whole batch immediately.On those server errors it recursively splits the call list in half, runs both halves in parallel, and concatenates results so output order still matches the input. A single remaining call uses the existing
ethCallpath. 4xx, JSON-RPC execution errors, and other non-5xx failures are unchanged (still thrown).A new unit test simulates 500 on array batch bodies and asserts four results in order after split retries (seven HTTP posts total).
Reviewed by Cursor Bugbot for commit b15a8fb. Bugbot is set up for automated code reviews on this repo. Configure here.