Skip to content

Fixes #215#216

Open
Skehmatics wants to merge 1 commit intoPolymerElements:masterfrom
Skehmatics:cancelFoRealThisTime
Open

Fixes #215#216
Skehmatics wants to merge 1 commit intoPolymerElements:masterfrom
Skehmatics:cancelFoRealThisTime

Conversation

@Skehmatics
Copy link
Copy Markdown

Fixes #215 by iterating through _active rather than _animations. This also could make canceling per-cookie/handler possible:

cancelAnimation: function(cookie) {
  for (var i in this._active[cookie]){
    this._active[cookie][i].animation.cancel();
  }
  delete this._active[cookie];
}

Tested in Chrome 55.

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@Skehmatics
Copy link
Copy Markdown
Author

@googlebot I signed it!

@googlebot
Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@Skehmatics
Copy link
Copy Markdown
Author

@googlebot I signed it! (again)

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants