Skip to content

libraries/lxqt-qtplugin: Fix cmake compilation error#387

Closed
isaackwy wants to merge 1 commit intoPonce:currentfrom
isaackwy:lxqt-qtplugin
Closed

libraries/lxqt-qtplugin: Fix cmake compilation error#387
isaackwy wants to merge 1 commit intoPonce:currentfrom
isaackwy:lxqt-qtplugin

Conversation

@isaackwy
Copy link
Copy Markdown
Contributor

This situation is similar to that of libfm-qt (cmake compilation error).

Again, I had received the following:

CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

  Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.

@github-actions
Copy link
Copy Markdown

reverse dependencies - libraries/lxqt-qtplugin

None

@github-actions
Copy link
Copy Markdown

✅ sbolint - libraries/lxqt-qtplugin ✅

lxqt-qtplugin: NOTE: lxqt-qtplugin.SlackBuild:61: LIBDIRSUFFIX gets set, but never used.
sbolint: lxqt-qtplugin checks out OK

@Ponce
Copy link
Copy Markdown
Owner

Ponce commented Mar 19, 2026

I could fix it here but be advised that it's safe to add that that cmake option also to SBo's script for stable (even "-DCMAKE_POLICY_VERSION_MINIMUM=3.10", that gets rid of another warning): I'm saying this because I just saw that you are the maintainer...

let me know how you prefer to go.

@isaackwy
Copy link
Copy Markdown
Contributor Author

isaackwy commented Mar 19, 2026

I would suggest that you fix it here.

What do you mean by that cmake option for stable though?
I'll consider it if I face a similar situation like this on Slackware-current again.

@Ponce
Copy link
Copy Markdown
Owner

Ponce commented Mar 19, 2026

I would suggest that you fix it here.

What do you mean by that cmake option for stable though?

that you could safely add it to the script you maintain on SBo, there should be no counter-effect having that option also on a script that have to be executed on 15.0...

this way you have also the advantage that you don't have to wait for me to fix it ;-)

@isaackwy
Copy link
Copy Markdown
Contributor Author

isaackwy commented Mar 19, 2026

Please merge this pull request to your current repo this time.
Related to the topic of cmake errors - for other scripts, I'll send the pull request to the main 15.0 SlackBuilds repo instead.

@Ponce
Copy link
Copy Markdown
Owner

Ponce commented Mar 19, 2026

thanks, pushed in its own branch!

@Ponce Ponce closed this Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants