Skip to content

Server to report configuration via meta#3

Merged
vertix merged 1 commit intomain-positronicfrom
server-meta
Nov 21, 2025
Merged

Server to report configuration via meta#3
vertix merged 1 commit intomain-positronicfrom
server-meta

Conversation

@vertix
Copy link
Contributor

@vertix vertix commented Nov 21, 2025

No description provided.

@vertix vertix merged commit 01f880d into main-positronic Nov 21, 2025
1 of 2 checks passed
@vertix vertix deleted the server-meta branch November 21, 2025 08:29
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +111 to +112
policy_metadata["config"] = args.policy.config
policy_metadata["directory"] = args.policy.dir

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Guard metadata enrichment for default policy

When the server is started without an explicit checkpoint (the default CLI path where args.policy is Default()), the new metadata assignments access args.policy.config and .dir, but the Default dataclass has no such attributes. This now raises an AttributeError before the websocket server is created, breaking the default-serving flow; only checkpoint-based invocations work. Consider populating these fields only when the policy is a Checkpoint.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant