feat: more electron decoupling#1654
Open
jonathanlab wants to merge 1 commit into04-14-feat_move_more_electron_dependencies_into_their_own_servicefrom
Open
feat: more electron decoupling#1654jonathanlab wants to merge 1 commit into04-14-feat_move_more_electron_dependencies_into_their_own_servicefrom
jonathanlab wants to merge 1 commit into04-14-feat_move_more_electron_dependencies_into_their_own_servicefrom
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does exactly what it says on the tin
Also adds a biome rule which prevents you from importing electron from anywhere but
apps/code/src/main/platform-adapters(+ some electron bootstrap file exemptions)Now basically everything electron related has been put in it's own little box where it can't hurt us when we want to extract the node server out to it's own package.