fix: prevent filepath wrapping in diff panel#1680
Open
reverb256 wants to merge 3 commits intoPostHog:mainfrom
Open
fix: prevent filepath wrapping in diff panel#1680reverb256 wants to merge 3 commits intoPostHog:mainfrom
reverb256 wants to merge 3 commits intoPostHog:mainfrom
Conversation
Wrap the directory path and bold filename spans in a single container with overflow:hidden, text-overflow:ellipsis, and whiteSpace:nowrap to prevent the browser from wrapping between the two spans on long paths. Adds a title attribute so users can hover to see the full path when truncated. Closes PostHog#1600
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Long filepaths in the diff review panel wrap between the gray directory path and bold filename, breaking visual alignment.
Closes #1600
Fix
Wrap both path segments in a single container with
nowrap+ellipsistruncation:whiteSpace: nowrapkeeps dir + filename on one lineoverflow: hidden+text-overflow: ellipsistruncates long pathstitleattribute shows full path on hoverTests
4 new tests in
ReviewShell.test.tsxverifying filepath rendering and nowrap behavior.