fix: preserve manual task rename from auto-generated title#1681
Open
reverb256 wants to merge 4 commits intoPostHog:mainfrom
Open
fix: preserve manual task rename from auto-generated title#1681reverb256 wants to merge 4 commits intoPostHog:mainfrom
reverb256 wants to merge 4 commits intoPostHog:mainfrom
Conversation
When a user manually renames a task, the auto-generated title from the LLM could overwrite it due to a race condition. The title_manually_set check only happened before the async generateTitleAndSummary() call, not after. Extract shouldApplyAutoTitle() into a separate pure function and call it both before and after the async generation to prevent the race. Fixes PostHog#1669
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When a user manually renames a task, the auto-generated title from the latest LLM message overwrites it. The
title_manually_setcheck only ran before the async title generation call, so if the user renamed during generation, the stale check passed.Closes #1669
Fix
Extracted
shouldApplyAutoTitle()pure function that readstitle_manually_setfrom the React Query cache. Called both before and after the async generation to prevent the race condition.Tests
5 new tests in
shouldApplyAutoTitle.test.tscovering all cases including the race condition.