Merged
Conversation
tatoalo
approved these changes
Apr 16, 2026
tatoalo
reviewed
Apr 16, 2026
| } from "@utils/session"; | ||
|
|
||
| const log = logger.scope("session-service"); | ||
| const LOCAL_SESSION_RECONNECT_ATTEMPTS = 3; |
Contributor
There was a problem hiding this comment.
Have observed any attempt at reconnect that failed? Not saying we don't need a counter here, just curios
Contributor
Author
There was a problem hiding this comment.
Mostly a safety net after coming up from sleep with other resources not being ready, bit of a guess since I don't really have a proof for it :)
vdekrijger
pushed a commit
that referenced
this pull request
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1563