Skip to content

test(flags): make wrong-key load_feature_flags deterministic #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andehen merged 6 commits into from
Feb 13, 2026
+14 −9
Merged

test(flags): make wrong-key load_feature_flags deterministic #432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
20afffc
test(flags): make wrong-key load_feature_flags deterministic
andehen Feb 13, 2026
899360e
fix(utils): enforce SizeLimitedDict cap on missing-key inserts
andehen Feb 13, 2026
7c75f33
Revert "fix(utils): enforce SizeLimitedDict cap on missing-key inserts"
andehen Feb 13, 2026
29424bb
test(flags): make capture memory-limit test deterministic
andehen Feb 13, 2026
67f9781
fix(flags): avoid implicit defaultdict insert in capture cache
andehen Feb 13, 2026
eddfb4b
test(flags): clarify deterministic cache-size setup
andehen Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions posthog/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1928,10 +1928,12 @@ def _capture_feature_flag_called(
f"{key}_{'::null::' if response is None else str(response)}"
)

if (
feature_flag_reported_key
not in self.distinct_ids_feature_flags_reported[distinct_id]
):
reported_flags = self.distinct_ids_feature_flags_reported.get(distinct_id)
if reported_flags is None:
reported_flags = set()
self.distinct_ids_feature_flags_reported[distinct_id] = reported_flags

if feature_flag_reported_key not in reported_flags:
properties: dict[str, Any] = {
"$feature_flag": key,
"$feature_flag_response": response,
Expand Down Expand Up @@ -1967,9 +1969,7 @@ def _capture_feature_flag_called(
groups=groups,
disable_geoip=disable_geoip,
)
self.distinct_ids_feature_flags_reported[distinct_id].add(
feature_flag_reported_key
)
reported_flags.add(feature_flag_reported_key)

def get_remote_config_payload(self, key: str):
if self.disabled:
Expand Down
9 changes: 7 additions & 2 deletions posthog/test/test_feature_flags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2513,7 +2513,10 @@ def test_load_feature_flags_clears_etag_when_server_stops_sending(
self.assertIsNone(client._flags_etag)
self.assertEqual(client.feature_flags[0]["key"], "flag-v2")

def test_load_feature_flags_wrong_key(self):
@mock.patch("posthog.client.Poller")
@mock.patch("posthog.client.get")
def test_load_feature_flags_wrong_key(self, patch_get, _patch_poll):
patch_get.side_effect = APIError(401, "Unauthorized")
client = Client(FAKE_TEST_API_KEY, personal_api_key=FAKE_TEST_API_KEY)

with self.assertLogs("posthog", level="ERROR") as logs:
Expand Down Expand Up @@ -4266,13 +4269,15 @@ def test_disable_geoip_get_flag_capture_call(self, patch_flags, patch_capture):
disable_geoip=False,
)

@mock.patch("posthog.client.MAX_DICT_SIZE", 100)
@mock.patch.object(Client, "capture")
@mock.patch("posthog.client.flags")
def test_capture_multiple_users_doesnt_out_of_memory(
self, patch_flags, patch_capture
):
client = Client(FAKE_TEST_API_KEY, personal_api_key=FAKE_TEST_API_KEY)
# Set on the instance to avoid relying on module-constant patching behavior
# across Python/runtime implementations.
client.distinct_ids_feature_flags_reported.max_size = 100
client.feature_flags = [
{
"id": 1,
Expand Down
Loading