feat: surface a coding-agent handoff prompt on wizard exit#595
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d7f5fbafc8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Hey @gewenyu99 — the reworked split is up per your review: this PR (#595, the wizard handoff) and PostHog/context-mill#174 (the "Verify before merging" checklist content). One thing: I added |
d7f5fba to
c3aca99
Compare
gewenyu99
left a comment
There was a problem hiding this comment.
:stamp: I am going to stamp the vibe of this code and promise to test this locally soon. Thanks for making these changes!
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #595 +/- ##
=======================================
Coverage ? 49.25%
=======================================
Files ? 215
Lines ? 8665
Branches ? 2043
=======================================
Hits ? 4268
Misses ? 4394
Partials ? 3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
c3aca99 to
b363c53
Compare
|
Thanks @gewenyu99! Two notes for your local test: Sequencing — this depends on PostHog/context-mill#174 landing/releasing first. The handoff points at the "Verify before merging" checklist the context-mill skill writes, so against the currently-published skill that section won't exist yet. How I tested it (there's probably a better/standard way — happy to switch): I ran context-mill's dev server ( |
b363c53 to
24ceb6f
Compare
|
Will get to this I :pinky-promise: soon |
14620c5 to
e182bf3
Compare
|
@ethangui Last thingm can you sign your commits? 🙏 |
Add OutroData.handoffPrompt, set per-program in buildOutroData and printed to the terminal's main buffer on exit (getExitLine). Rides on main's getUI().setOutroData() delivery, so the prompt reaches the outro data without any extra plumbing. Verification content lives in context-mill. Refs PostHog#447. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
9125d3e to
0fb7660
Compare
commits signed 👍 |




Problem
Refs #447. The wizard finishes by writing
posthog-setup-report.md, but there's a gap between "wizard done" and "PostHog merged" — the developer (or their coding agent) has to rediscover the remaining verification + glue steps.This is the wizard half; the verification content lives in context-mill (PostHog/context-mill#174). Supersedes #448 (reworked per @gewenyu99's review — content moved to context-mill, wizard slimmed to the handoff).
Changes
OutroData.handoffPrompt, set per-program inbuildOutroData, built bybuildCodingAgentPrompt.getExitLine, extracted toexit-line.ts).Builds on main's recently-merged
getUI().setOutroData()outro delivery — the builtOutroData(includinghandoffPrompt) reaches the store through that path, so no extra plumbing is needed here.Why this shape:
releaseTerminal()is the only thing that survives in scrollback and triple-click-selects cleanly. An in-TUI version was tried first and reverted for this reason.handoffPromptis a narrow, program-setOutroDatafield — product copy stays in the program'sbuildOutroData; infra (exit-line) stays product-agnostic and renders an optional string.Sequencing: depends on PostHog/context-mill#174 merging + releasing first — the prompt references the "Verify before merging" checklist the context-mill skill writes.
Test plan
pnpm build,pnpm test(819 passing),pnpm lintall green. New tests cover the exit-line handoff rendering (exit-line) and the prompt wording/consent (handoff).codexsecond-opinion pass on both repos. The one finding — a dev-only skills-URL env override that widened a trust boundary — was dropped from this PR (kept local-only).identify;$ai_generationcorrectly absent;@posthog/aiinstrumentation and the checklist correctly gained the$ai_generationitem.LLM context
Co-authored with Claude Code (Opus 4.8). Reviewed via the multi-agent +
codexpasses noted above before opening. Follows this repo's PR template and the PostHog CONTRIBUTING / AI policy.cc @PostHog/team-docs-wizard
🤖 Generated with Claude Code