Add vagrant support and environemnt variables#4
Open
geromueller wants to merge 3 commits intoPostcon:masterfrom
Open
Add vagrant support and environemnt variables#4geromueller wants to merge 3 commits intoPostcon:masterfrom
geromueller wants to merge 3 commits intoPostcon:masterfrom
Conversation
geromueller
commented
Jul 13, 2018
geromueller
commented
- calls vagrant ssh -c "cmd"
- prepend ENV=var to commands
DrSchimke
reviewed
Jul 16, 2018
Contributor
DrSchimke
left a comment
DrSchimke
left a comment
There was a problem hiding this comment.
Could you please add a few lines to the README.md mentioning vagrant and the new "env" parameter.
| */ | ||
| public function iRun($command, $server = 'default') | ||
| { | ||
| $server = str_replace('-', '_', $server); |
Contributor
There was a problem hiding this comment.
Why do you replace minus signs by underscore here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.