fix: restore wait_for_http health check for interface-service before integration tests#8
Open
circleci-app[bot] wants to merge 3 commits into
Open
Conversation
…integration tests
… check in CI The wait_for_http step for interface-service was polling http://localhost:3567/health, but the interface-service has no /health endpoint of its own — it only proxies routes to downstream services (e.g. /project/health, /user/health). Hitting /health on port 3567 always returns a 404, which curl -sf treats as a failure, causing the health check to exhaust all 60 retries and time out after 180 s. Fix: change the URL to http://localhost:3567/project/health?basicCheck=true. - /project/health is a registered route in the interface-service (via the elevate-project package loaded from elevate-routes.json) that proxies to the project-service on :5003. - basicCheck=true skips the circular microservice dependency checks, consistent with the fix already applied to the direct project-service health check URL.
…vice-proxy-health-check fix: use /project/health?basicCheck=true for interface-service health check in CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wait_for_httphealth check for interface-service (http://localhost:3567/health) before integration tests run489d7af("trigger ci")Root Cause
The
user-serviceroutes entity-management calls through interface-service (ENTITY_MANAGEMENT_SERVICE_BASE_URL=http://localhost:3567/entity-management). When integration tests run before interface-service is fully ready, user creation requests that involve entity-management hang indefinitely.With
no_output_timeout: 5mon the test step and mocha-junit-reporter writing output to an XML file (not stdout), CircleCI kills the process after 5 minutes of no console output — producing the empty test output seen in the CI failure.Fix
Added
wait_for_httpfor interface-service back in the correct position (after all other service health checks, before running integration tests):Test plan
Original failing job
https://app.circleci.com/agents/circleci/3c4df9e5-2e07-4dba-99a6-6a869f03d07e/chat/e798ddf4-c407-4699-a9cd-0a3ce68523d9