Open
Conversation
- Add MarketCardSkeleton / MarketsListSkeleton for markets widget - Add EventDetailSkeleton for event detail page - EventsTableSkeleton already existed; wired via loading.tsx - Add AsyncButton: inline spinner + loading text, no layout shift - Add ErrorBanner: destructive alert with optional Retry action - Wire EventDetailSkeleton + ErrorBanner into event-page/page.tsx - Wire ErrorBanner + retry into EventsSection (events-store error state) - Add /loading-patterns demo page covering all 3 core surfaces
- KpiCard: label, value, unit, delta, tooltip — 2-col mobile / 4-col desktop grid - ChartPanel: consistent title/description/responsive height wrapper - chart-styles.ts: shared colors, axis tick, grid, tooltip, margin constants - VolumeChart: line chart with XLM Y-axis label and formatted tooltip - DistributionChart: horizontal bar chart with % X-axis and per-category colors - analytics/page.tsx: full page wiring KPI strip + both chart panels
|
@johnsmccain is attempting to deploy a commit to the Jagadeesh B's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@johnsmccain Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
markdown
feat(design): analytics layout and chart style guide
Summary
Implements the analytics page layout with KPI cards, chart panels, and
shared chart style rules. Covers both mobile and desktop breakpoints.
Changes
components/analytics/kpi-card.tsx— KPI card with label, value,unit, delta indicator, and info tooltip
components/analytics/chart-panel.tsx— Consistent wrapper for allchart panels (title, description, responsive height)
components/analytics/chart-styles.ts— Single source of truth forcolors, axis ticks, grid, tooltip, and margins
components/analytics/volume-chart.tsx— Line chart: monthlyprediction volume with XLM-labelled Y-axis
components/analytics/distribution-chart.tsx— Horizontal bar chart:market category share with %-labelled X-axis
app/(dashboard)/analytics/page.tsx— Analytics page wiring KPIstrip and both chart panels
Layout
Chart style rules
--chart-1…5CSS variables (theme-consistent)muted-foreground, no axis/tick linesChartTooltipContentTesting
pnpm exec tsc --noEmitpasses (no new type errors)/analyticswithpnpm dev-Close #115
Branch
design/analytics→main