Skip to content

Plots: refactor for stability, robustness, and expanded test coverage#335

Open
eliotmcintire wants to merge 1 commit intodevelopmentfrom
PlotsImprovements
Open

Plots: refactor for stability, robustness, and expanded test coverage#335
eliotmcintire wants to merge 1 commit intodevelopmentfrom
PlotsImprovements

Conversation

@eliotmcintire
Copy link
Copy Markdown
Contributor

Summary

  • Stable filename generation using sim time (avoids timing-based instability)
  • Error surfacing for failed base-R device saves (warning + failedFiles tracking)
  • isBaseFormat variable to clarify base-R vs ggplot save path; funsUsed co-located with filenamesForSave in setup block; simplified useCache condition
  • New tests covering: base-R plotting fn (hist), terra SpatRaster/SpatVector, named ... args without data =, ggplot object passed directly as data

Test plan

  • All existing Plots tests pass (PASS 37 locally)
  • New tests: base-R fn saves png + raw qs2, terra raster saves tif raw, terra vector saves qs2 raw, named ... args, direct ggplot data
  • R CMD check locally
  • GHA CI passes

🤖 Generated with Claude Code

- Stable filename generation using sim time (avoids timing-based instability)
- Error surfacing for failed base-R device saves (warning + failedFiles tracking)
- isBaseFormat variable to clarify base-R vs ggplot save path
- funsUsed co-located with filenamesForSave in setup block
- Simplified useCache condition
- New tests: base-R fn, terra SpatRaster/SpatVector, named ... args, direct ggplot data

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant