Plots: refactor for stability, robustness, and expanded test coverage#335
Open
eliotmcintire wants to merge 1 commit intodevelopmentfrom
Open
Plots: refactor for stability, robustness, and expanded test coverage#335eliotmcintire wants to merge 1 commit intodevelopmentfrom
eliotmcintire wants to merge 1 commit intodevelopmentfrom
Conversation
- Stable filename generation using sim time (avoids timing-based instability) - Error surfacing for failed base-R device saves (warning + failedFiles tracking) - isBaseFormat variable to clarify base-R vs ggplot save path - funsUsed co-located with filenamesForSave in setup block - Simplified useCache condition - New tests: base-R fn, terra SpatRaster/SpatVector, named ... args, direct ggplot data Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
failedFilestracking)isBaseFormatvariable to clarify base-R vs ggplot save path;funsUsedco-located withfilenamesForSavein setup block; simplifieduseCachecondition...args withoutdata =, ggplot object passed directly asdataTest plan
PASS 37locally)...args, direct ggplotdataR CMD checklocally🤖 Generated with Claude Code